search

bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
125 stars 21 forks source link

gtk2: ripStatus: ruby 2.5 compliant format strings #613

Closed Warepire closed 6 years ago

Warepire commented 6 years ago

Avoids the following crash while extracting a CD with ruby 2.5:

 #<Thread:0x00007f3dd82f1710@/bin/rrip_gui:77 run> terminated with exception (report_on_exception is true):
 Traceback (most recent call last):
         2: from /bin/rrip_gui:85:in `block in update'
         1: from /usr/lib/rubyripper/gtk2/ripStatus.rb:40:in `updateProgress'
 /usr/lib/rubyripper/gtk2/ripStatus.rb:40:in `%': incomplete format specifier; use %% (double %) instead (ArgumentError)
 Traceback (most recent call last):
         2: from /bin/rrip_gui:85:in `block in update'
         1: from /usr/lib/rubyripper/gtk2/ripStatus.rb:40:in `updateProgress'
 /usr/lib/rubyripper/gtk2/ripStatus.rb:40:in `%': incomplete format specifier; use %% (double %) instead (ArgumentError)
PharmaceuticalCobweb commented 6 years ago

+1 please merge.

rubyripper is currently broken for me with the same argument error.

Thank you for resurrecting one of my favourite pieces of software :)

bleskodev commented 6 years ago

Hi, thanks for fixing this! I apologize for the slow reply.