Refacto budget - Githubissues

bleucitron / open-books

https://open-books.now.sh

MIT License

8 stars 7 forks source link

Refacto budget #114

Closed bleucitron closed 2 years ago

bleucitron commented 2 years ago

[x] switch back to sirens-based urls
[x] write fillBudgetBySirens (use .map instead of .forEach) and fillBudgetBySiret
[x] in context="module", redirect to url with siret and sirens if (!siret || !sirens) (see Svelte-Kit doc)
[x] cache budgets in budgetCache (never reset) and budgetById (reset when $city changes)

Caching tips

fillBudgetBySirens

Retrieving cache from budgetCache for fillBudgetBySirens can be tricky. For each siren:

get all sirets from cache
filter those which start with siren
if the filtered sirets array is not empty, return the array of all these keys, and remove siren from the local sirens array
if not, fetch normally with getRecords

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ourson/open-books/7ewJ4KuMNw3asLoGMRwC2JPJsyBs
✅ Preview: https://open-books-git-refacto-budget-ourson.vercel.app