search

bleupen / halacious

a better HAL processor for Hapi
MIT License
108 stars 22 forks source link

updated dependencies #94

Closed travi closed 8 years ago

travi commented 8 years ago

closes #93

I went ahead and ran updtr to get a few more up to date. It runs npm test between each update, so as long as thats enough to verify the functionality, these should all be good.

I did not take a shot at the ones that didn't update smoothly, so joi and lodash are still out of date.

bleupen commented 8 years ago

thanks for the PR!

do you have an opinion on how to semver a release with these changes? everything seems to be backward compatible in terms of API, but do you think big changes in dependencies constitute a "breaking change"?

travi commented 8 years ago

Looks like my previous response ended up not going through :/ Sorry about that.

My interpretation has always been:

Unless there are other changes in the release or the dependencies change some behavior exposed through the api, I normally lean toward patch with this type of release.

Sorry again for the delay. Would love to see a release published and be able to clean up these security issues.

Thanks!