search

blhendricks / project-blhendricks

GNU General Public License v3.0
1 stars 0 forks source link

Event_Generator.jl #2

Open azeolla opened 2 years ago

azeolla commented 2 years ago

On line 28 you define attributes["n_events"] = n_events but then on line 45 n_events = attributes["n_events"]. This is circular.

azeolla commented 2 years ago

Line 55 data_sets["zz"] = zero(data_sets["zz"]). Why not have generate_vertex_positions() already set the z values to 0?

azeolla commented 2 years ago

Some lines could use comments, like 51-52 and 62. It is difficult for me to tell what is happening in these lines.

azeolla commented 2 years ago

I think a better method of running the sim could be implemented rather than having to edit the two lines at the bottom using a text editor every time. I see that you import ArgParse, which I do recommend. If you end up not using ArgParse then I recommend removing that import since it slows down your sim.

azeolla commented 2 years ago

Do the integers representing the different neutrino flavors have some kind of physical meaning? What does flavor=[12,-12,14,-14,16,-16] mean?