search

blhendricks / project-blhendricks

GNU General Public License v3.0
1 stars 0 forks source link

Support_Funcs.jl #3

Open azeolla opened 2 years ago

azeolla commented 2 years ago

Most functions are missing documentation and comments. Some functions (such as get_neutrino_inelasticity()) could also use references.

azeolla commented 2 years ago

Where are functions ice_cube_nu_fit() and get_GZK_1() defined?

azeolla commented 2 years ago

Variable volume_full (lines 125 & 162) appears to be identical to V (lines 135 & 173). I don't think you need to define both.

azeolla commented 2 years ago

set_volume_attributes() determines whether or not a user has specified a cylinder or a cube based on the keys present within the dictionary volume. It is not clear to a user looking only at Event_Generator.jl what keys are valid though.

azeolla commented 2 years ago

set_volume_attributes() seems to be doing a lot just to set some parameters of attributes to some parameters of volume. I think this likely could be condensed, although it'll take some thinking as to figure out exactly how. The more if statements that can be eliminated, the more efficient the code will be.