[BUG]: Many items cause slow rendering

blib-la / LoRAdo

LoRAdo is a UI that allows easy creation of LoRAs for stable diffussion

GNU Affero General Public License v3.0

25 stars 1 forks source link

[BUG]: Many items cause slow rendering #4

Open pixelass opened 1 year ago

pixelass commented 1 year ago

Describe the bug

When I upload more that 10 images, the caption editing is noticably slower. At 20 images it is extremely laggy

Expected behavior

editing captions should be fast/immediate

Screenshots

Versions (please complete the following information):

Browser: [Chrome 115.0.5790.171]
Node.js: [v18.17.1]
OS: [windows 11]
LoRAdo [e.g. 0.1.0-alpha-3]

Additional context

as reported in #3

pixelass commented 1 year ago

we could look into this library, but sadly there doesn't seem to be any documentation: https://tanstack.com/virtual/v3/docs/examples/react/variable

There are some examples but it is unclear if this library can handle items with images. They have a masonry example but it is very simple and the sizeEstimation seems to be something that must be done manually (something we would have to think about)

pixelass commented 1 year ago

Some improvements were made in the lastes release v0.1.0-alpha.4. It's not perfect but a lot faster than before.