search

blib-la / blibla-comfyui-extensions

Extensions for ComfyUI
GNU Affero General Public License v3.0
138 stars 11 forks source link

Nodes Resizing when Queue Prompt Clicked #12

Closed WinstonWoof closed 2 months ago

WinstonWoof commented 10 months ago

with these extensions installed (even latest version) seeing the issue in the video below

https://www.youtube.com/watch?v=5MuVu3J0AtE

https://github.com/comfyanonymous/ComfyUI/issues/1417 also refers

pixelass commented 10 months ago

Thank you for reporting. There is an option that does batch resizing. With the extension loaded, can you please create a screenshot of the options modal (click the gear/cogwheel icon)

WinstonWoof commented 10 months ago

I can tell you without looking that that was enabled :)

I would need to reinstall the extensions to see if the behaviour is the same with that disabled

On moment caller

WinstonWoof commented 10 months ago

can confirm that I'm seeing the same behaviour with "allow group selection resize" enabled or disabled

pixelass commented 9 months ago

@WinstonWoof Sorry for the silence. I'm currently very busy. I am now starting to look into the open issues but was not able to reproduce the issue. Can you list all extensions you have active when this occurs? It might be a conflict of two extensions/custom nodes.

Thank you.

DrJKL commented 2 months ago

I'm getting this too. I think it's an interaction with this ShowText node. It has a resize hook here that then triggers your patched onResize.

pixelass commented 2 months ago

@DrJKL Thank you for the useful information. I will test and see if I can fix it. Otherwise I might just remove the batch resizing as it is extremely hacky.

DrJKL commented 2 months ago

I wonder if there's a way to check to see if the resize "event" is coming from a selected node.

DrJKL commented 2 months ago

I was thinking of adding a custom "node" pack that dealt with sizing/layout, since that's something I often get annoyed by.

pixelass commented 2 months ago

@DrJKL I really don't use ComfyUI ATM (focusing on some other stuff right now) so I can't look into the API of Litegraph. Also it's such an oldschool early 2000s API so I'm not really excited when working with it.

Our addons were just a bunch of hacks when ComnfyUI was pretty new. I just added some clientside helpers that I found useful back then, that's it.

We are very happy that people find it useful and will try to support it as long as it is in use but it's currently a really low priority.

Trying to be transparent here ;)

pixelass commented 2 months ago

fixed since I removed the extension See: https://github.com/blib-la/blibla-comfyui-extensions/issues/16#issuecomment-2102806775