search

blib-la / blibla-comfyui-extensions

Extensions for ComfyUI
GNU Affero General Public License v3.0
154 stars 10 forks source link

the way this extension override `afterChange` may break other extensions #14

Closed SunriseFox closed 7 months ago

SunriseFox commented 10 months ago

This extension saves current app.graph.afterChange on init but override afterChange on setColorMode (which is invoked async and way after the setup process).

saves here:

https://github.com/failfa-st/failfast-comfyui-extensions/blob/b67e161b434e92a36a0d42871a455bf1ff60e6d7/extensions/colors.js#L276-L277

overrides here and invokes here:

https://github.com/failfa-st/failfast-comfyui-extensions/blob/b67e161b434e92a36a0d42871a455bf1ff60e6d7/extensions/colors.js#L187

https://github.com/failfa-st/failfast-comfyui-extensions/blob/b67e161b434e92a36a0d42871a455bf1ff60e6d7/extensions/colors.js#L261-L275

So any other extensions that register afterChange callback and setup after this extension won't work properly...

pixelass commented 8 months ago

Thank you for reporting this issue. We will look into it and report back.