blib-la / runpod-worker-comfy

ComfyUI as a serverless API on RunPod
GNU Affero General Public License v3.0
301 stars 205 forks source link

[BUG]: Docker Image didn't posted into docker hub repository #62

Open alka7ex opened 2 months ago

alka7ex commented 2 months ago

Describe the bug

i'm trying to build the docker images using github actions, however after the github actions done and everything looks good, the repo didn't appear in the dockerhub

Repro MVP (Minimal Viable Procedure)

the base of the github actions .yml file with a bit of modifications especially on the secrets `name: Release

on: workflow_dispatch: push: branches:

jobs: release: runs-on: ubuntu-latest if: ${{ !contains(github.event.head_commit.message, 'chore(release)') }} permissions: contents: write # to be able to publish a GitHub release issues: write # to be able to comment on released issues pull-requests: write # to be able to comment on released pull requests

steps:
  - name: Checkout
    uses: actions/checkout@v3
    with:
      persist-credentials: false

  - name: Set up Python
    uses: actions/setup-python@v4
    with:
      python-version: "3.10"

  - name: Install dependencies
    run: pip install -r requirements.txt

  - name: Clear space to remove unused folders
    run: |
      rm -rf /usr/share/dotnet
      rm -rf /opt/ghc
      rm -rf "/usr/local/share/boost"
      rm -rf "$AGENT_TOOLSDIRECTORY"

  - name: Set up QEMU
    uses: docker/setup-qemu-action@v3

  - name: Set up Docker Buildx
    uses: docker/setup-buildx-action@v3

  - name: Login to Docker Hub
    uses: docker/login-action@v3
    with:
      username: ${{ secrets.DOCKERHUB_USERNAME }}
      password: ${{ secrets.DOCKERHUB_TOKEN }}

  - name: Update the ToC in the README.md
    run: npx markdown-toc README.md -i

  - name: Semantic release
    uses: codfish/semantic-release-action@v3
    id: semanticrelease
    with:
      additional-packages: |
        ['@semantic-release/git', '@semantic-release/changelog']
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Use default GitHub token or your custom token

  - name: Set environment variables
    if: steps.semanticrelease.outputs.new-release-published == 'true'
    run: |
      echo "DOCKERHUB_REPO=${{ vars.DOCKERHUB_REPO }}" >> $GITHUB_ENV
      echo "DOCKERHUB_IMG=${{ vars.DOCKERHUB_IMG }}" >> $GITHUB_ENV
      echo "HUGGINGFACE_ACCESS_TOKEN=${{ secrets.HUGGINGFACE_ACCESS_TOKEN }}" >> $GITHUB_ENV
      echo "RELEASE_VERSION=${{ steps.semanticrelease.outputs.release-version }}" >> $GITHUB_ENV

  - name: Build and push the images to Docker Hub
    if: steps.semanticrelease.outputs.new-release-published == 'true'
    uses: docker/bake-action@v2
    with:
      push: true
      set: |
        *.args.DOCKERHUB_REPO=${{ env.DOCKERHUB_REPO }}
        *.args.DOCKERHUB_IMG=${{ env.DOCKERHUB_IMG }}
        *.args.RELEASE_VERSION=${{ env.RELEASE_VERSION }}
        *.args.HUGGINGFACE_ACCESS_TOKEN=${{ env.HUGGINGFACE_ACCESS_TOKEN }}

  - name: Update description on Docker Hub
    if: steps.semanticrelease.outputs.new-release-published == 'true'
    uses: peter-evans/dockerhub-description@v3
    with:
      username: ${{ secrets.DOCKERHUB_USERNAME }}
      password: ${{ secrets.DOCKERHUB_TOKEN }}
      repository: ${{ env.DOCKERHUB_REPO }}/${{ env.DOCKERHUB_IMG }}

`

Expected behavior

the image should be appear in the dockerhub

Screenshots

image image

Versions (please complete the following information):