Missing attendance CD - Githubissues

blibli-future / athens

0 stars 1 forks source link

Missing attendance CD #6

Closed riencus closed 7 years ago

riencus commented 7 years ago

I've just realized that we haven't implemented the CD for the Attendance. Beside that, I think the R and U for attendance is implemented inside EmployeeTappingService with processGetTapping and processUpdateTapping method.

Question I wanna ask:

Should it have some method to directly create an Attendance data not a tap data?
Should we separate the tappingService and attendanceService?

Opinion @aamesaa , @sebastianbagya , @kabal86 , anybody?

yogiehartanto commented 7 years ago

@arielchristianto what is CD = ?, R = ?, U = ?

riencus commented 7 years ago

Sorry for being not clear enough. CRUD as in Create Read Update Delete

yogiehartanto commented 7 years ago

Should we separate the tappingService and attendanceService? i think it's related, so you should not separate it

sebastianbagya commented 7 years ago

I think we can create a C for full attendance data. So attendance can be tapped in and out immediately.

riencus commented 7 years ago

I think we can create a C for full attendance data. So attendance can be tapped in and out immediately.

On where I should implement this @sebastianbagya? EmployeeTappingService? Or should I make a new Service just for this?

sebastianbagya commented 7 years ago

@arielchristianto, EmployeeTappingService because its part of tapping. What do you think @aamesaa ?