Fix build with new gtfs-realtime.proto

bliksemlabs / rrrr

RRRR rapid real-time routing

BSD 2-Clause "Simplified" License

164 stars 32 forks source link

Fix build with new gtfs-realtime.proto #171

Closed PaulWagener closed 9 years ago

PaulWagener commented 9 years ago

The removed attribute ADDED in TripUpdate in the GTFS specification caused a build error in tdata_realtime_expanded.c See https://github.com/bliksemlabs/rrrr/commit/ea15a69d2ed32067d82ac3f34252aca161eb1ba4#diff-a405d2bd76f9fde04d450d18d45532ceL206 for the breaking change and https://travis-ci.org/bliksemlabs/rrrr/jobs/51377118 for the compiler error

koch-t commented 9 years ago

I was just blaming @skinkie for this, not sure if we will merge this PR. Probably makes more sense to re-add the ADDED to stoptimeupdate. The realtime code is up for a re-do

PaulWagener commented 9 years ago

I don't grok the code enough to evaluate the impact of this change, so I'll just leave this open as a temporary stop-gap solution.

skinkie commented 9 years ago

Added the ADDED back to the protobuf file. Or better put: I finally pushed the work. Closing this pull request, thanks anyway for taking a peak at the error.