search

blimmer / cdk-datadog-integration

Amazon Cloud Development Kit (CDK) logic to integrate your AWS account with Datadog
Apache License 2.0
19 stars 8 forks source link

CDK core pinned at exactly 1.35.0 #16

Closed plumdog closed 3 years ago

plumdog commented 3 years ago

See https://github.com/blimmer/cdk-datadog-integration/blob/master/package.json#L48

This gives me problems using this with Typescript, because the version I'm installing is far more recent, so I have two conflicting versions (this might also cause problems without Typescript, but certainly Typescript catches this:

lib/myfile.ts:15:37 - error TS2345: Argument of type 'this' is not assignable to parameter of type 'Construct'.
  Type 'MyStack' is not assignable to type 'Construct'.
    Property 'onValidate' is protected but type 'Construct' is not a class derived from 'Construct'.

I think the answer is to relax the CDK version requirement.