search

blind-contours / CVtreeMLE

:deciduous_tree: :dart: Cross Validated Decision Trees with Targeted Maximum Likelihood Estimation
MIT License
5 stars 1 forks source link

Linting #14

Closed lightning-auriga closed 2 years ago

lightning-auriga commented 2 years ago

This isn't absolutely required, but it would be really nice to have this package passed through full linting. I know it can be a bit of a pain, but it can really help encourage best practices. As an example, I use precommit with a config as follows:

repos:
  ## R support
- repo: https://github.com/lorenzwalthert/precommit
  rev: v0.2.2
  hooks:
  - id: style-files
  - id: parsable-R
  - id: no-browser-statement
  - id: lintr
    verbose: true
  - id: roxygenize
  - id: deps-in-desc
  - id: use-tidy-description
blind-contours commented 2 years ago

A majority of the package has been linted now to the style guide of the tlverse. There is still some things to do but for the most part the coding is aligned with best practices.

lightning-auriga commented 2 years ago

Great. The remainder of the formatting warnings can be deferred until such time as you look to post on CRAN or something like that.