search

blind-contours / CVtreeMLE

:deciduous_tree: :dart: Cross Validated Decision Trees with Targeted Maximum Likelihood Estimation
MIT License
5 stars 1 forks source link

Long installation time #23

Open wleoncio opened 1 year ago

wleoncio commented 1 year ago

Not necessarily a deal-breaker for using this package, but an annoyance especially when one needs to install the package multiple times (for testing on a machine or for use on multiple ones): first installation on my 8th-gen i5 CPU took no less than 30 minutes.

I'm glad to see a CRAN release on the roadmap, hopefully this will reduce the amount of dependencies and compiled code involved.

Is there anything more short-term that could be done, though?

blind-contours commented 1 year ago

Hi @wleoncio - I found 2 packages that are used in the tests and can be moved to suggests so I did that. I think the other thing I can do to remove the number of dependencies is to make the simulation scripts used in the readme, vignette, and paper not actually part of the package which would cut back 1 package in imports. I can try and think of some other things to try and reduce install time. The issue is that the CVtreeMLE package relies on a lot of other packages that take time to install namely, PRE, partykit, SL3, furrr etc. Let me know if you have some other ideas.

wleoncio commented 1 year ago

Thank you for addressing this issue. I understand there's not much that can be done as long as there are so many dependencies (see issue #26), so I guess a long installation is something users will have to live with for a while.