Add Windows to build CI workflow

blind-contours / CVtreeMLE

:deciduous_tree: :dart: Cross Validated Decision Trees with Targeted Maximum Likelihood Estimation

MIT License

5 stars 1 forks source link

Add Windows to build CI workflow #25

Closed wleoncio closed 1 year ago

wleoncio commented 1 year ago

I noticed the build CI file contains Linux and macOS builds. It would be nice to also include a Windows check in there (even if that's the platform you're developing on), so that the tests are more comprehensibe by including non-Unix OSs, and would benefit contributors not on Windows machines (there are dozens of us. Dozens!)

blind-contours commented 1 year ago

Hi @wleoncio - I've added windows to the build file. I think originally I removed this because a version of SL3@devel was failing install on windows and I couldn't figure out why (not related to CVtreeMLE). I've added it back and I'll see if it passes the tests on Windows now.

wleoncio commented 1 year ago

Thanks for taking care of this. The Windows check seems to still contain an SL3-related issue, but I would rather have an issue opened to take care of it later than drop the OS check altogether.