search

blindly / vscode-puppet

Puppet Language and Snippets Support for Visual Studio Code
MIT License
9 stars 5 forks source link

Syntax checking and linting support #2

Open mafredri opened 8 years ago

mafredri commented 8 years ago

Have you thought about adding syntax checking and linting support to this extension as well?

If puppet is installed on the system, puppet parser validate filename.pp can be used to see if the file parses correctly (and know where the errors are).

It would also be nice to have puppet-lint (installable as a gem) for linting purposes.

dhollinger commented 8 years ago

+1

pjmagee commented 8 years ago

There is another Puppet Linter visual studio extension which exists. Maybe some communication with the author of that extension we could potentially merge the two into one Puppet Development Extension Utopia.

blindly commented 8 years ago

I have reached out to the author of the extension but have not heard back from him yet.

pjmagee commented 7 years ago

The author seems active but hasn't got back still. Maybe it's worth poking to get a response. If not, maybe we could expand on this current one to also include puppet linter similar to the other extension.

The other extension has an MIT license so I see no reason why we need to hold back on making this extension the default and only extension needed for anyone interested in doing puppet code in VSCode.

@jgreat The extension is very specific to Puppet Linter. Where as it appears that this extension is named as "Puppet Extension for Visual Studio Code", making it seem like a more well rounded and capable of more features extension for puppet code.

It already has 5K downloads and is clearly more popular, I say we push and get the puppet linter added.

May I also suggest the puppet parser validate? :)

jgreat commented 7 years ago

I don't have any issue with combining into one package. What can I do to help?

pjmagee commented 7 years ago

Seems like both Authors were in agreement as the package seems to be merged. There's also a PR for Puppet Parser Validate.

Let's get this issue closed?