search

blindsidenetworks / mattermost-plugin-bigbluebutton

BigBlueButton plugin for Mattermost :electric_plug:
Apache License 2.0
89 stars 43 forks source link

Remove meetings without recordings from recording queue after a few hours #100

Closed mkuron closed 3 years ago

mkuron commented 4 years ago

It seems like meetings without recordings are never removed from the plugin's recording queue. I am currently seeing hundreds of messages like

{"level":"info","ts":1591090363.608135,"caller":"mlog/sugar.go:19","msg":"Successfully got recordings info","plugin_id":"bigbluebutton"}

in the Mattermost log every two minutes. Looking at the code, i can see that the loop counter is never incremented anywhere, so the check that removes a meeting from the queue after 144 iterations (approximately 4 hours and 48 minutes) never fires. This pull request fixes that.

H-B-Schmidt commented 3 years ago

It would be nice to get a fix. Our server log is flooded with

2020-11-19T07:23:48.069+0100 info mlog/sugar.go:19 Successfully got recordings info {"plugin_id": "bigbluebutton"}

moschlar commented 3 years ago

Yes, please....

harshilsharma63 commented 3 years ago

@mkuron thanks for the fix! Can't believe this was missed. We'll release this as part of v2.2.