search

blindsidenetworks / mattermost-plugin-bigbluebutton

BigBlueButton plugin for Mattermost :electric_plug:
Apache License 2.0
89 stars 43 forks source link

Adminonly+accessibility+fix #112

Closed bastiion closed 3 years ago

bastiion commented 4 years ago

Hey there,

this is a combined pull request that includes https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton/pull/96 and it solves some accessibility issues, this plugin had. It uses buttons wherever possible, because empty a anchors cannot be reached with tab by blind people. (We actually had those issues in a conference).

Additionally it fixes a bug, that the feature "direct BBB call" wasn't working. https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton/commit/8862d9a207b94552d8f68b8ac3970097ac498352

harshilsharma63 commented 3 years ago

HI @bastiion thanks for the fix! We've merged a few pull requests into master and it seems now your branch contains some of these changes and some changes which we decided not to merge. Can you bring your branch in sync with the latest master?

harshilsharma63 commented 3 years ago

@bastiion I've gone through your changes and make a new PR for those - https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton/pull/123.