search

blindsidenetworks / mattermost-plugin-bigbluebutton

BigBlueButton plugin for Mattermost :electric_plug:
Apache License 2.0
89 stars 43 forks source link

Make the join url accessible to the user. #124

Closed Schleuse closed 3 years ago

Schleuse commented 3 years ago

This change loads the joinUrl in the state of the PostTypebbb-Component when the component mounts and renders the loaded url as the href-Attribute of the Join-Meeting Button. This makes it possible to copy the URL and use it for example on another machine.

May also fix issue #57

harshilsharma63 commented 3 years ago

@Schleuse thanks for the PR! There are a few issues with doing so though,

  1. When you request the join URL from the API, it assumes the user has joined the meeting, and so updates the list of attendees in the post. This is of course wrong as it gives the false impression that the user joined the meeting, when in fact they didn't.
  2. I'm concerned that if we allow users to access the join URL, they'll pass it around to other users as well. This would be wrong as the meeting join URL is user-specific to manage their role, name and password.