blindsidenetworks / mattermost-plugin-bigbluebutton

BigBlueButton plugin for Mattermost :electric_plug:
Apache License 2.0
89 stars 43 forks source link

"Meeting created" message tags the wrong user #185

Open nough opened 3 years ago

nough commented 3 years ago

When creating meetings in a chat, the bigbluebutton bot sometimes tags the wrong user. Not posting image. Assume we have two users: Alice Jones Alice Smith

BigBlueButton (BOT)
Meeting created by @(Alice Jones) Smith
Attendees: Alice Smith
Join Meeting --- End Meeting
harshilsharma63 commented 2 years ago

@nough thanks for reporting this. Looks like the incorrect username is in the Meeting created by field, correct?

Can you share the two user's usernames? Feel free to send me an email (address in profile) if it's something you don't want to share in public

nough commented 2 years ago

Yes, incorrect username in Meeting created by field, but it looks like you're putting in their fullname then autocompleting on it. In terms of my users, their Mattermost usernames are different from the second letter, e.g. @asmith, @ajones, but they have different display names like Alice Jones and Alice Smith Another instantiation of this issue is where a user does not have a duplicate name (say, there's only one Bob in the company). In this case, the message reads something like:

BigBlueButton (BOT)
Meeting created by @(Bob Davies) Davies
Attendees: Invited Todo bot to this meeting
Join Meeting --- End Meeting

where (Bob Davies) is the link to the user, and Davies is their surname, unlinked.

ajones commented 2 years ago

@nough 👋 i think you meant to tag a different ajones

nough commented 2 years ago

@nough 👋 i think you meant to tag a different ajones

Apologies, I didn't mean to tag anyone, was just too busy thinking about things to think about ensuring people didn't get tagged.

harshilsharma63 commented 2 years ago

@nough that's interesting. For the user displayed incorrectly, can you check what's their First Name, Last Name and Nickname set in Mattermost? Also what's your teammate name display setting?

Screenshot 2021-10-22 at 6 40 03 AM

r

nough commented 2 years ago

I changed my display setting to "show username", which then changed the @ for my personal meeting invite to:

Meeting created by @(username) surname

where (username) is linked to my user. I imagine if one of the users with a duplicate name did this then it would still register the wrong person.

harshilsharma63 commented 2 years ago

I tried reproducing this it worked fine for me. Can you tell your Mattermost and BBB plugin version?

nough commented 2 years ago

Ah, My apologies for a) not including that information to begin with, and b) not considering that it would have such an effect, and c) not checking for updates.

Mattermost version 5.37 bbb-plugin v3.2.1

We previously chose not to update to v4.0 as it includes a UX deterioration, in that users have to search for the "join meeting" message to click on it, and have to click three times instead of twice. (I appreciate this is because of the mobile integration).

harshilsharma63 commented 2 years ago

We previously chose not to update to v4.0 as it includes a UX deterioration, in that users have to search for the "join meeting" message to click on it, and have to click three times instead of twice. (I appreciate this is because of the mobile integration).

I think this is a common pain point for many users. I'll see if we can somehow open the link automatically on browser/desktop app.