Make plugin compatible with Mattermost running in HA mode

blindsidenetworks / mattermost-plugin-bigbluebutton

BigBlueButton plugin for Mattermost :electric_plug:

Apache License 2.0

89 stars 43 forks source link

Closed ghost closed 2 years ago

ghost commented 4 years ago

One quick thing I found is this-

p.Meetings = append(p.Meetings[:index], p.Meetings[index+1:]...)

We shouldn't store data in memory and used KV store instead.

ghost commented 4 years ago

Currently we save all meeting data form memory to KV store on plugin deactivation. This will lead to information loss when plugin crases as reported by @hanzei at https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton/pull/44#discussion_r295326385 .

harshilsharma63 commented 2 years ago

This is fixed now. We no longer handle meeting data in memory and use mutex locked access to KV store.