Fix race condition when opening meeting tab

blindsidenetworks / mattermost-plugin-bigbluebutton

BigBlueButton plugin for Mattermost :electric_plug:

Apache License 2.0

89 stars 43 forks source link

Fix race condition when opening meeting tab #86

Closed zorun closed 3 years ago

zorun commented 4 years ago

Clicking on "Join Meeting" would sometimes redirect to the blindsidenetworks website, especially on chrome. Fix this by opening about:blank instead.

While we're at it, properly handle error conditions when joining the meeting doesn't work.

Note: changing post_type_bbb.jsx was enough to solve the bug. However, there is very similar code in root.jsx, so I also fixed the issue there (just in case).

Tested with Firefox 75 and Chromium 81.

Fixes #85

jdanders commented 4 years ago

:+1: from me. I just applied the change from https://blindsidenetworks.com to about:blank to the current plugin by unzipping, editing, and rezipping, and that fixed the issue of being forwarded to the other website while using Chromium 79.