blindsidenetworks / scalelite

Scalable load balancer for BigBlueButton.
GNU Affero General Public License v3.0
470 stars 247 forks source link

Panic does not end and clear meetings when Multitenancy is enabled #1010

Closed Ithanil closed 1 year ago

Ithanil commented 1 year ago

Describe the bug

When Multitenancy is enabled, the panic rake task does not end and clear the meetings on the panicked server. According to the code, the panicServer API call should also be affected, but this is not tested.

To Reproduce

Enable Multitenancy, create a meeting, panic the server. Meeting keeps running, does not get cleared, but the server will be disabled.

Deployment: SL 1.5.1.5 custom docker-compose

Expected behavior

Panic should end all meetings on the server and clear the ended meetings, like it does when multitenancy is NOT enabled.

Additional context

Cause of the issue is that Meeting.all needs the tenant id as parameter to list all meetings of the tenant. Without tenant id, the list of meetings is empty.

There might be more places in the code with similar issues. Likely affected (aside from tests/spec):

Also see https://github.com/blindsidenetworks/scalelite/issues/993

https://github.com/blindsidenetworks/scalelite/issues/889 probably unrelated.

Ithanil commented 1 year ago

Fixed with https://github.com/blindsidenetworks/scalelite/pull/1012 / https://github.com/blindsidenetworks/scalelite/releases/tag/v1.5.1.6