blindsidenetworks / scalelite

Scalable load balancer for BigBlueButton.
GNU Affero General Public License v3.0
470 stars 247 forks source link

Using LRS basic auth does not work #1059

Closed lunika closed 3 months ago

lunika commented 5 months ago

Describe the bug

In version 1.5.2-beta.1 it is allowed to use a Basic auth token to connect to a LRS by using the rake command tenants:update_lrs_basic. When this token is sent to BBB, it uses the same token parameter than a OIDC connection https://github.com/blindsidenetworks/scalelite/blob/v1.5.2-beta.1/app/services/lrs_payload_service.rb#L10

And the in BBB, if lrs_token is not empty, then a Bearer authorization is used instead of a Basic one: https://github.com/bigbluebutton/bbb-webhooks/blob/c5eaddb9f66ffbcd9c0acdcf067b401e818ae4c1/src/out/xapi/xapi.js#L55

So defining a basic auth for a LRS in scalelite does not work. Everytime it is the Bearer authorization that is used in BBB.

farhatahmad commented 4 months ago

Hi Manual - there's some small changes we can make on Scalelite's side, but the majority of the work needs to be done on the web hooks side to get this working. I'll coordinate with the BBB team to try and get this done

ffdixon commented 3 months ago

WIP: https://github.com/bigbluebutton/bbb-webhooks/pull/47

farhatahmad commented 3 months ago

Fixed: https://github.com/blindsidenetworks/scalelite/pull/1080