blindsidenetworks / scalelite

Scalable load balancer for BigBlueButton.
GNU Affero General Public License v3.0
465 stars 249 forks source link

ScaleLite currently doesn't work on ports other than 443 (or possibly 80) #262

Closed EmmyGraugans closed 2 years ago

EmmyGraugans commented 4 years ago

In the file app/controllers/bigbluebutton_api_controller.rb in or around line 252 the variable url_prefix is set without taking into account the possibly non-standard port. The result is that recordings get the wrong URL and are shown in (e.g.) greenlight with broken thumbnails and cannot be played back.

The original line

@url_prefix = "#{request.protocol}#{request.host}"

should probably instead better be

@url_prefix = "#{request.protocol}#{request.host_with_port}"

If one wanted to be perfectionist, one could check if the port is different from standard and include the port only in that case, but it probably doesn't make any difference, if the standard-port is written there as well.

jfederico commented 2 years ago

Linked to #178