init-recordings-bigbluebutton.sh fixes

[JeanPluzo]

Describe the bug There are some small bugs in the script init-recordings-bigbluebutton.sh, namely:

• it's not clear whether to use -s or -h in the small help included in the script.
• the port and id_rsa parameters are not taken into account

To Reproduce run the script with parameters.

Deployment:

1. Deployment: docker-compose
2. Versions: BBB 2.4.6, Scalelite 1.3.2, Docker Engine 20.10.14, docker-compose 1.29.2, Ubuntu 18.04
3. Tools used for reproducing the issue: script, trial-and-error

Steps to reproduce the behavior: Executed script with parameters (init-recordings-bigbluebutton.sh -s scalelite.server -p 1234 -u some-user -r some-id_rsa). -r and -p parameters were not taken into account.

Expected behavior -p and -r parameters should change the port and the name of the id_rsa file.

Additional context I changed these lines and everything worked:

• Line 10: was -h, changed to -s (this is only the inline help)
• Line 26: was ...getopts "s:u:p" opt, changed to ...getopts "s:u:p:r:" opt
• Line 117: was ...~/.ssh/id_rsa, changed to ...~/.ssh/${ID_RSA:-id_rsa}
• Line 151: was .../bigbluebutton/.ssh/id_rsa.pub, changed to .../bigbluebutton/.ssh/${ID_RSA:-id_rsa}.pub I know it's better to make a pull request, but since the changes are small, perhaps the bug will be "merged" faster.

Thanks!

Regards,

J.

[JeanPluzo]

I just upgraded SL to 1.4.2. I noticed these fixes are not included in this version (1.4.2) nor in the latest (1.5.1). Just commenting/bumping hoping these fixes are merged. @jfederico could you take a look? Porfa y gracias!