blindsidenetworks / scalelite

Scalable load balancer for BigBlueButton.
GNU Affero General Public License v3.0
465 stars 249 forks source link

undefined local variable or method `request' for RecordingReadyNotifierService:Class #979

Closed Tecumtha closed 1 year ago

Tecumtha commented 1 year ago

After the Rreport from Issue: #971, i updated to Version 1.5.1.1.

blindsidenetwks/scalelite:v1.5.1.1-recording-importer blindsidenetwks/scalelite:v1.5.1.1-poller
blindsidenetwks/scalelite:v1.5.1.1-api

The rest of the configuration is the same as in the previous Issue in #971.

Now I have a new error:

I, [2023-06-29T09:02:47.578108 #6] INFO -- : Recording Ready Notify for [8h7eqb5l8tdpvsiow1dysirnpvjeegabaakcz8op] starts I, [2023-06-29T09:02:47.578483 #6] INFO -- : Making callback for recording ready notification I, [2023-06-29T09:02:47.578834 #6] INFO -- : Rescued I, [2023-06-29T09:02:47.581832 #6] INFO -- : undefined local variable or method `request' for RecordingReadyNotifierService:Class request.host.split(".").first ^^^^^^^ Did you mean? require

pielonet commented 1 year ago

Hello, I had the same problem when testing today !

The faulty code is here : https://github.com/blindsidenetworks/scalelite/blob/83698249c8be454dd3cdc4f5d2b7a9beedc2ea99/app/controllers/concerns/api_helper.rb#L66

farhatahmad commented 1 year ago

Sorry about that - there was a use case that I missed while testing

farhatahmad commented 1 year ago

Can you try out the latest image (https://github.com/blindsidenetworks/scalelite/releases/tag/v1.5.1.2) and let me know how that goes?

Tecumtha commented 12 months ago

I've tested this a bit now and it works as expected, thanks