blindsidenetworks / scalelite

Scalable load balancer for BigBlueButton.
GNU Affero General Public License v3.0
470 stars 247 forks source link

`servers:enable[some_invalid_id]` should return with exit code `!= 0` #999

Open debuglevel opened 1 year ago

debuglevel commented 1 year ago

servers:enable[some_invalid_id] returns with exit code 0. It should return with some greater value.

Furthermore, it prints ERROR: No server found with id: ... on stdout instead of stderr.

scouillard commented 1 year ago

Hi,

All the RecordNotFound in servers rake task will now return the exit status 1.

I hear you on the idea of sending the logs to stderr instead of stdout. However, we've been doing it like this everywhere else in the project. We are open to discussing the subject further if there's a strong case for it.

As always, thanks for your time and dedication.

Ithanil commented 6 months ago

So can this issue be closed now @debuglevel ?