search

blindsidenetworks / wordpress-plugin_bigbluebutton

BigBlueButton Wordpress Integration
GNU General Public License v2.0
27 stars 39 forks source link

Bug fixes and cleanup #2

Closed jaydonovan closed 11 years ago

jaydonovan commented 12 years ago

Fixed bug preventing widget from appearing Changed how meetings are created and joined so recording works. Changed $welcome to be global variable in some functions, probably need to do the same with other variables to ensure they can be changed.
Currently setting of voice bridge is a 'Russian Roulette' like function where a random channel is chosen from a pool of 10k possibilities. Would like to eventually allocate those channels smarter. Cleaned up grammar & spelling in some comments. Added some questions in comments regarding what functions do. Function names aren't sufficent. Standardized on "welcomeString" instead of "welcome" within bbb_api.php - seemed to be what Jesus had started to do.

jfederico commented 11 years ago

The comments are confusing and unnecessary for the official repository. Also the fix for the widget is not right because is using a method deprecated in 2.7.

For future pull request it would be better to make single commits per fix or function added.