Closed seenaburns closed 3 years ago
@seenaburns apologies for the super long delay getting back here. would you be able to rebase against the latest so we can get this merged?
As this issue hasn't been touched in a few months I decided to rebase the changes to pull request https://github.com/bling/fzf.el/pull/63 so that it can be merged soon.
https://github.com/bling/fzf.el/pull/63 has been merged.
As brought up in bling/fzf.el/issues/24, fzf.el has set up fzf in emacs, but could be extended to work with many other things. This PR refactors fzf.el into 3 main functions:
fzf-with-entries (entries action &optional directory)
: run fzf, passing in an elisp list and running the function action with the user's selected resultsfzf-with-command (command action &optional directory)
: run a shell command and directly pass to fzf. An optimization on top offzf-with-entries
so that the output does not have to be stored in emacs before sending to fzf anyway.fzf-base (action &optional directory)
: run fzf with the user's defaultFZF_DEFAULT_COMMAND
Users then can define their own functions like
But a handful of common functions like
fzf-files
andfzf-grep
are predefined.This PR does some other things as mentioned in the first commit (e.g. handle exit codes, cleaning up fzf), but in general I'm happy to work with you if you'd like it to be shaped differently.