Generalize fzf.el into a completion engine with fzf

seenaburns commented 6 years ago

As brought up in bling/fzf.el/issues/24, fzf.el has set up fzf in emacs, but could be extended to work with many other things. This PR refactors fzf.el into 3 main functions:

fzf-with-entries (entries action &optional directory): run fzf, passing in an elisp list and running the function action with the user's selected results
fzf-with-command (command action &optional directory): run a shell command and directly pass to fzf. An optimization on top of fzf-with-entries so that the output does not have to be stored in emacs before sending to fzf anyway.
fzf-base (action &optional directory): run fzf with the user's default FZF_DEFAULT_COMMAND

Users then can define their own functions like

(defun fzf-example ()
  (fzf-with-entries
   (list "a" "b" "c")
   'print))

But a handful of common functions like fzf-files and fzf-grep are predefined.

This PR does some other things as mentioned in the first commit (e.g. handle exit codes, cleaning up fzf), but in general I'm happy to work with you if you'd like it to be shaped differently.

bling commented 3 years ago

@seenaburns apologies for the super long delay getting back here. would you be able to rebase against the latest so we can get this merged?

rolag commented 3 years ago

As this issue hasn't been touched in a few months I decided to rebase the changes to pull request https://github.com/bling/fzf.el/pull/63 so that it can be merged soon.

NightMachinery commented 3 years ago

Also take a look at my fork, which is based on @seenaburns fork. I have a PR open there, though I have committed some extra stuff since I wrote that PR.

bling commented 3 years ago

https://github.com/bling/fzf.el/pull/63 has been merged.

bling / fzf.el

Generalize fzf.el into a completion engine with fzf #39