Closed gvoysey closed 2 years ago
I'm seeing the same behavior but with M-x fzf-git
. For example, in a Chromium checkout I have a buffer open for src/content/browser/
. The git root is src/.git
. I do an M-x fzf-git
and select weblayer/test/browsertests_main.cc
. I see the string target weblayer/test/browsertests_main.cc appear in the minibuffer, but it doesn't open the file. I'm on version 20210619.1421
of the fzf package.
Any updates on this ?
Yes this is also an issue for me on emacs 28 with native-comp.
I suspect the problem was introduced in this large change: https://github.com/bling/fzf.el/commit/23c09c9c0417c7de67a8965d9b506d0cc7aea7a2#diff-534c53b4b453a9e60d31e86fc6e43a483723ede793bba723d39cf9954f543195R153
This PR seems to be solving this issue (at least for fzf-git-files
): https://github.com/bling/fzf.el/pull/65
@bling is there any chance we can merge and release this? Or anyone else interested with the right permissions in this repo?
I would love to use this package again, i'm using projectile as a backup and don't like at all.
merged the referenced MR, should be all good now.
confirmed. thank you!
When I run
M-x fzf RET
and then find a file match which is a valid file but not an open buffer already, no new buffer is opened but the stringtarget <the thing i matched>
is displayed in the minibuffer.Is this expected behavior?