bling / fzf.el

A front-end for fzf
GNU General Public License v3.0
369 stars 50 forks source link

Add support for custom narrowing #73

Closed ghost closed 2 years ago

ghost commented 2 years ago

Note: This PR is heavily informed by the fzf advanced use documentation. For complete context, do read the documentation. Although the documentation mentions ripgrep specifically, the ideas expand to any kind of custom narrowing (although the performance gain may not)

Changes

in descending priority order

Breaking Changes

None. All function signatures have been updated to add tail optional params, or in the case of fzf-grep, updated to maintain parity with the previous implementation.

Upcoming

I tested all the functions by hand to check for regressions, but this package is growing beyond that. I am going to look into adding unit tests next.

bling commented 2 years ago

@sayeefm0 looks good, any other pending changes?

ghost commented 2 years ago

Not at the moment. I'm gonna continue working on the package though, so I'm sure I'll have more in the future : )