search

bling / fzf.el

A front-end for fzf
GNU General Public License v3.0
360 stars 50 forks source link

Fix fzf/position-bottom defcustom type declaration bug & fix byte compiler warnings #83

Closed pierre-rouleau closed 1 year ago

pierre-rouleau commented 1 year ago

Which prevented its customization to work properly. There is no 'bool type. It's 'boolean.

pierre-rouleau commented 1 year ago

The fixed reference to free variable is what it says it is: just a fix to prevent the warning. However this code looks suspicious and should probably be changed.

pierre-rouleau commented 1 year ago

@bling, you may want to take a look at lispy to help you write lisp code. Trailing closing parens in separate lines in lisp code is not the style you should use.

bling commented 1 year ago

@bling, you may want to take a look at lispy to help you write lisp code. Trailing closing parens in separate lines in lisp code is not the style you should use.

this is due to multiple contributions from different people. if you want the entire file to be consistent, please open a separate PR independent of the defcustom fix. thanks.

pierre-rouleau commented 1 year ago

@bling, I will first fix all byte compile warnings. I started with the defcustom error and then fixed several issues in that stream of pull request. There are some warnings that remain and I'll fix them as soon as I get some time.

pierre-rouleau commented 1 year ago

@bling, I fixed all byte compiler warnings as detected by Emacs 26.3 . I'll check with Emacs 27 and 28 soon.

pierre-rouleau commented 1 year ago

@bling, would it be possible to merge in these PRs? I have found other warnings I'd like to push. I have also found a scenario where the lines returned by fzf includes trailing spaces which cause the use in Emacs to fail. I have fix for those as well. I will report this second issue as a bug and would like to provide a fix for that. Thanks!

pierre-rouleau commented 1 year ago

Thanks @bling !