Fix regression on fzf grep command + minor improvements

bling / fzf.el

A front-end for fzf

GNU General Public License v3.0

360 stars 50 forks source link

Fix regression on fzf grep command + minor improvements #90

Closed pierre-rouleau closed 1 year ago

pierre-rouleau commented 1 year ago

Fix regression in fzf--action-find-file-with-line introduced when changed code to use forward-line. The function moved to 1 line below the target. It now moves to the proper line.
Refactoring:
- Rename fzf/window-register to fzf--window-register, since the register is not meant to be used by user code.
- Also clarified its docstring.
- Clarified fzf-grep docstring.
Regrouping:
- Move fzf-git-grep inside the VCS-related command code area.

pierre-rouleau commented 1 year ago

@bling I noticed the grep commands were moving 1 line below the real target since I started using forward-line. I fixed that. Tested the grep commands they now move to the proper line.

pierre-rouleau commented 1 year ago

@bling Thanks. My nest step will be to add support for hg grep which has the ability to grep through all revisions, and change the code for extracting the line number to support more formats and allow files with embedded colons. I'll probably use Elisp regexps for that.