bling / fzf.el

A front-end for fzf
GNU General Public License v3.0
360 stars 50 forks source link

New, more flexible filename/line extraction logic. #92

Closed pierre-rouleau closed 1 year ago

pierre-rouleau commented 1 year ago

Changed the file name and line number extraction logic of a grep-like operation to use Emacs Lisp regular expression, allowing extraction of file names with any embedded characters (including colons) while also allowing user code to override the regular expression and the matching groups used to extract the file and line numbers.

Tested.

I believe this address the issue reported by https://github.com/bling/fzf.el/pull/51 in a way that will be more flexible if the user wants to use tools that produce a different output than FILE:LINE:text.

pierre-rouleau commented 1 year ago

@bling I tested that code on Emacs 28.2, and 26.3. I believe it's ready for integration. Let me know if you notice something wrong.

pierre-rouleau commented 1 year ago

@bling I have also tested the new customization. I believe everything is good to go.