Await watch call - Githubissues

blinkdb-js / blinkdb

🗃️ An in-memory JS database optimized for large scale storage on the frontend.

https://blinkdb.io

MIT License

119 stars 10 forks source link

Closed llamadeus closed 1 year ago

llamadeus commented 1 year ago

Add missing await to calls to watch(...) so subsequent inserts get caught by the watcher and furthermore to allow stopping the watcher properly.

Fixes #9.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	e328aa07f0f2d081b0b0ace5ba345e0e191c52a7
Latest deploy log	https://app.netlify.com/sites/blinkdb/deploys/645031d2eec19d000833b16d
Deploy Preview	https://deploy-preview-10--blinkdb.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

maradotwebp commented 1 year ago

Thanks for noticing the issue, and for your quick website fix :)

~~It's probably also a good idea if you were to update the JSDoc comments in watch.ts as well, they also don't include the await keyword yet.~~

I've reworked watch() & added them there myself. Will merge this asap.