Cannot use classes like `ItemNotFoundError` because target is set to `es5`

blinkdb-js / blinkdb

🗃️ An in-memory JS database optimized for large scale storage on the frontend.

https://blinkdb.io

MIT License

119 stars 10 forks source link

Cannot use classes like `ItemNotFoundError` because target is set to `es5` #21

Closed powerpaul17 closed 1 year ago

powerpaul17 commented 1 year ago

I cannot check an error with instanceof ItemNotFoundError because in the compiled file classes get converted into functions. I think it is because you target es5 in the tsconfig.json.

I don't know if it is desired/necessary to target es5 for some reason, otherwise would it be possible to change it to es6?

Thank you for this great project! :slightly_smiling_face:

maradotwebp commented 1 year ago

Yep, I'm taking a look at it.

maradotwebp commented 1 year ago

Nice! That was exactly the problem. Fixed in the latest release.