Closed pengten closed 4 years ago
@yy1098029419 谢谢贡献,但有几个点需要说一下:
mvn compile
命令应该会报格式问题的,或者你的 Intellij idea
里面配置我项目中的 Checkstyle 文件,检查下看看 ;enableDistinct()
默认值设置为 false
吧,这样默认情况下会保持先下兼容,而且 distinct
的情况偏少,减少没必要的代码运行;Pattern pattern = Pattern.compile(REGX_SELECT_FROM);
的 Pattern
应该做成 static final
的,不用每次运行都去编译,全局只需编译一次就行了,增加运行速度。@blinkfox checkStyle文件用idea导入报错
@blinkfox checkStyle文件用idea导入报错
版本选 8.30
@blinkfox 按照checkstyle修正完成。
Merging #24 into develop will decrease coverage by
0.44%
. The diff coverage is12.50%
.
@@ Coverage Diff @@
## develop #24 +/- ##
===========================================
- Coverage 78.79% 78.35% -0.45%
===========================================
Files 105 105
Lines 2023 2037 +14
Branches 289 291 +2
===========================================
+ Hits 1594 1596 +2
- Misses 319 331 +12
Partials 110 110
Impacted Files | Coverage Δ | |
---|---|---|
...ain/java/com/blinkfox/fenix/jpa/FenixJpaQuery.java | 68.37% <12.50%> (-7.36%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c391e0b...4c03a71. Read the comment docs.
@yy1098029419 我先给你合了,不过单元测试率降低了,你抽空补一下单元测试吧,代码更靠谱点儿。
我单元测试里面使用的是 HSQLDB
内存数据库,你参考我的代码,补充一些关于这些 distinct
查询的测试用例。
解决issue11,添加countSql对distinct的支持。