codecov-io commented 4 years ago

Codecov Report

Merging #7 into develop will decrease coverage by 14.03%. The diff coverage is 20.32%.

@@             Coverage Diff             @@
##           develop      #7       +/-   ##
===========================================
- Coverage    82.43%   68.4%   -14.04%     
===========================================
  Files           52      90       +38     
  Lines         1264    1633      +369     
  Branches       178     227       +49     
===========================================
+ Hits          1042    1117       +75     
- Misses         141     435      +294     
  Partials        81      81

Impacted Files	Coverage Δ
.../blinkfox/fenix/specification/page/PageConsts.java	`0% <0%> (ø)`
.../blinkfox/fenix/specification/util/FieldUtils.java	`0% <0%> (ø)`
...ion/listener/impl/LikeinSpecificationListener.java	`0% <0%> (ø)`
...om/blinkfox/fenix/specification/page/PageUtil.java	`0% <0%> (ø)`
...blinkfox/fenix/specification/page/PageAndSort.java	`0% <0%> (ø)`
...nix/specification/BuildSpecificationException.java	`0% <0%> (ø)`
...m/blinkfox/fenix/specification/util/SortUtils.java	`0% <0%> (ø)`
...linkfox/fenix/specification/util/JpaQueryUtil.java	`0% <0%> (ø)`
...ication/predicate/FenixBooleanStaticPredicate.java	`0% <0%> (ø)`
...blinkfox/fenix/specification/util/StringUtils.java	`0% <0%> (ø)`
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f27fff...4abe211. Read the comment docs.

blinkfox commented 4 years ago

@yy1098029419 单元测试率降低了，你抽空补一下才能合。

blinkfox commented 4 years ago

@yy1098029419 如果你没写单元测试的话，我还是先合了吧，不过我自己抽空补上，并很有可能会对你的代码再做很多修改。

pengten commented 4 years ago

好的，收假前补上单元测试------------------ 原始邮件 ------------------ 发件人: "闪烁之狐 (blinkfox)"notifications@github.com 发送时间: 2020年1月13日(星期一) 下午5:51 收件人: "blinkfox/fenix"fenix@noreply.github.com; 抄送: "yy1098029419"1098029419@qq.com;"Mention"mention@noreply.github.com; 主题: Re: [blinkfox/fenix] 集成Jpaplus的基于VO注解的查询 (#7)

@yy1098029419 如果你没写单元测试的话，我还是先合了吧，不过我自己抽空补上，并很有可能会对你的代码再做很多修改。

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

pengten commented 4 years ago

代码比较粗糙，希望老师多指点------------------ 原始邮件 ------------------ 发件人: "闪烁之狐 (blinkfox)"notifications@github.com 发送时间: 2020年1月13日(星期一) 下午5:51 收件人: "blinkfox/fenix"fenix@noreply.github.com; 抄送: "yy1098029419"1098029419@qq.com;"Mention"mention@noreply.github.com; 主题: Re: [blinkfox/fenix] 集成Jpaplus的基于VO注解的查询 (#7)

@yy1098029419 如果你没写单元测试的话，我还是先合了吧，不过我自己抽空补上，并很有可能会对你的代码再做很多修改。

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

blinkfox / fenix

集成Jpaplus的基于VO注解的查询 #7

Codecov Report