blinkfox / jpack-maven-plugin

这是一个用于对 SpringBoot 服务打包为 Windows、Linux、Docker、Helm Chart下可部署包的 Maven 插件。
Apache License 2.0
57 stars 13 forks source link

Update AbstractBaseMojo.java #4

Closed yyjob closed 4 years ago

yyjob commented 5 years ago

refactor(mojo) 新增是否清理target目录配置项

codecov-io commented 5 years ago

Codecov Report

Merging #4 into develop will decrease coverage by 12.28%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop       #4       +/-   ##
============================================
- Coverage    80.97%   68.69%   -12.29%     
============================================
  Files           22       22               
  Lines          757      757               
  Branches        92       92               
============================================
- Hits           613      520       -93     
- Misses         108      188       +80     
- Partials        36       49       +13
Impacted Files Coverage Δ
...main/java/com/blinkfox/jpack/AbstractBaseMojo.java 77.04% <0%> (-19.68%) :arrow_down:
...java/com/blinkfox/jpack/consts/DockerGoalEnum.java 0% <0%> (-70%) :arrow_down:
...blinkfox/jpack/handler/impl/DockerPackHandler.java 34.97% <0%> (-28.42%) :arrow_down:
...n/java/com/blinkfox/jpack/consts/PlatformEnum.java 74.19% <0%> (-25.81%) :arrow_down:
.../java/com/blinkfox/jpack/consts/SkipErrorEnum.java 81.81% <0%> (-18.19%) :arrow_down:
...rc/main/java/com/blinkfox/jpack/entity/Docker.java 90.9% <0%> (-6.07%) :arrow_down:
...om/blinkfox/jpack/handler/AbstractPackHandler.java 66.66% <0%> (-5.72%) :arrow_down:
...om/blinkfox/jpack/handler/PlatformPackContext.java 73.68% <0%> (-5.27%) :arrow_down:
.../main/java/com/blinkfox/jpack/entity/PackInfo.java 97.01% <0%> (-2.99%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc110fb...45f1013. Read the comment docs.

blinkfox commented 5 years ago

@yyjob 为啥你提交的代码,覆盖率下降了这么多,你新增了部分代码,单元测试也得跟着修改才行。

yyjob commented 5 years ago

好的,第一次向github提交代码,很多地方不太熟悉,做得不好的地方还请多多指教

------------------ 原始邮件 ------------------ 发件人: "闪烁之狐 (blinkfox)"<notifications@github.com>; 发送时间: 2019年10月22日(星期二) 上午10:06 收件人: "blinkfox/jpack-maven-plugin"<jpack-maven-plugin@noreply.github.com>; 抄送: "backstroke"<270792717@qq.com>; "Mention"<mention@noreply.github.com>; 主题: Re: [blinkfox/jpack-maven-plugin] Update AbstractBaseMojo.java (#4)

@yyjob 为啥你提交的代码,覆盖率下降了这么多,你新增了部分代码,单元测试也得跟着修改才行。

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

blinkfox commented 5 years ago

@yyjob 嗯,你最好也多测几遍哈

yyjob commented 5 years ago

好的

------------------ 原始邮件 ------------------ 发件人: "闪烁之狐 (blinkfox)"<notifications@github.com>; 发送时间: 2019年10月22日(星期二) 上午10:17 收件人: "blinkfox/jpack-maven-plugin"<jpack-maven-plugin@noreply.github.com>; 抄送: "backstroke"<270792717@qq.com>; "Mention"<mention@noreply.github.com>; 主题: Re: [blinkfox/jpack-maven-plugin] Update AbstractBaseMojo.java (#4)

@yyjob 嗯,你最好也多测几遍哈

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.