search

blinksh / blink

Blink Mobile Shell for iOS (Mosh based)
https://blink.sh
GNU General Public License v3.0
6.15k stars 575 forks source link

Codespaces opens in web window #1674

Open christopherseaman opened 1 year ago

christopherseaman commented 1 year ago

Checklist

Configuration

Blink v16.0.4.644 GitHub Codespaces extension 1.13.5 iPadOS 16.2 (20C65) iPad Air (4th gen)

Describe the bug

Opening a new or existing GitHub Codespace via UI in code opens the Codespace within a web window instead of via tunnel. Note: GitHub remote repositories and vscode-server tunnels both function as expected.

Steps to recreate:

  1. Open blink, launch code
  2. Have the GitHub Codespaces extension installed
  3. On the remote tab, GitHub Codespaces, click "Create Codespace" button (or connect to existing codespace, or cmd-P -> "Codespaces: Connect to Codespace")
  4. If required: login, select repo + branch, cores + memory
  5. Toast appears "creating codespace..." on the bottom right
  6. Blink prompt "The browser interrupted the opening of a new tab or window. Press 'Open' to open it anyway." with the URL of the Codespace "https://username-adjective-noun-hash.github.dev/"
  7. Click "Open" (other options are Cancel and Learn More)
  8. Web window opens with the Codespace and repo loaded

Expected behavior: Expect local code to tunnel to remote, local UI to reflect the remote state, and the lower left corner to display ">< Codespaces"

IMG_0038

yilewang commented 1 year ago

I got same issue… hope this could be solved soon

irreal commented 1 year ago

Does anyone have a workaround I can use? I can't figure out any way to connect to my github codespace from blink code editor...

yury commented 1 year ago

@irreal press safari icon, copy url and run code <url>

christopherseaman commented 1 year ago

Thanks, @yury - confirming your workaround to get Codespaces working by taking a detour through Safari (feel like there should be a good pun there)

  1. Start/open a codespace -> opens in a web view
  2. Tap Safari icon
  3. Copy URL from Safari
  4. Return to Blink, close Code
  5. code <URL FROM SAFARI> to open codespace fullscreen
PCreations commented 2 months ago

Or you can just click on the "open in visual studio code" link instead of "open in browser", and it will open in blink :)