search

blinksh / blink

Blink Mobile Shell for iOS (Mosh based)
https://blink.sh
GNU General Public License v3.0
6.13k stars 570 forks source link

Problem with color scheme and with non-ASCII characters #201

Open LATBauerdick opened 7 years ago

LATBauerdick commented 7 years ago

I'm a user of the Blink App from the AppStore, and wanted to submit an issue report. I attach two screenshots of a neovim session of a file, once in blink on an iPad Pro using the solarized dark theme, the other using iTerm2 on a Mac (using exactly the same setup otherwise). The issues are quite obvious, it would be great if someone could have a look at that!

The screenshots are here, for Blink iPad Pro and iTerm2.

Thank you, LatB

carloscabanero commented 7 years ago

Hi! Thanks a lot for your message! I need more information, but usually this happens with fonts that have a character that doesn't play well with monospace. Which font are you using? Blink's fonts shouldn't have any problem but maybe we haven't seen a problem in one of them. I also see that in the iTerm you have "ligatures" enabled but not in Blink.

LATBauerdick commented 7 years ago

Thanks for your quick reply!

I’m using the provided Source Code Pro font. How do I enable “ligatures” in Blink? (sorry, I could probably find that in the docs somewhere… :-)

However, I’m not using ligatures but “unicode symbol” support in vim through https://github.com/enomsg/vim-haskellConcealPlus

I also see that using powerline the “|>” symbol does not always display — sometimes it doesn’t display initially but then later it suddenly works. Something is not quite right with font handling.

The other thing is how solarized colors are displayed (could be with other color schemes, too). Somehow the window background that should be the darkest shade gets a lighter shade instead, while the cursor highlight line is dark when it should be lighter. The status line and line number areas also pick up the wrong background color (compared to iterm and other terminal emulators). Again, this is with the “out-of-the-box” configuration, no extra fonts and no extra color schemes.

Obviously this is not the most urgent issue, but would be nice to be looked at!

Thanks and best regards, LatB

On 5 Dec 2016, at 19:09, carloscabanero wrote:

Hi! Thanks a lot for your message! I need more information, but usually this happens with fonts that have a character that doesn't play well with monospace. Which font are you using? Blink's fonts shouldn't have any problem but maybe we haven't seen a problem in one of them. I also see that in the iTerm you have "ligatures" enabled but not in Blink.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/blinksh/blink/issues/201#issuecomment-265030329

carloscabanero commented 7 years ago

Sorry for not getting back to you sooner. Would you mind trying a font like the included Fira Code to see if that actually solves the issue? this happens because some fonts, even if monospaced, do not have the same width all the time, specially for some patched characters. ITerm doesn't have that problem because their rendering happens per character, but on HTerm, the emulator we use, unfortunately that's not the case.

About Solarized on iTerm, iTerm has an option to modify the colors to "improve" contrast. We follow the colors from the theme and I wonder if that's why you see them differently.

carloscabanero commented 7 years ago

Brain fart on last paragraph. I see what you are saying and will review from our side. There is just no way that can be contrast.

yury commented 6 years ago

Can't see original screenshots... But issue seems to be outdated.