I don't understand why you need algo files when js would be just fine

blinktrade / algorithm-trading

List of blinktrade approved algorithm trading strategies

GNU General Public License v3.0

227 stars 109 forks source link

I don't understand why you need algo files when js would be just fine #1

Open totty90 opened 9 years ago

pinhopro commented 9 years ago

That was a bad decision. Hard to change now :/

totty90 commented 9 years ago

I've noticed this and other issues. I would suggest to look into webpack + gulp to improve your code structure.

Also another tip would be to use standard names for things. For example classes are named like this: MyBot.js´ and notmy_bot.js. Also the instance of the class is like thisvar myBot = new MyBot()`.

I also don't understand the methods and properties with a ending _. I use these coding practices:

Private method/property: __myMethod;
Protected: _myMethod;
Public: myMethod;

cesardeazevedo commented 8 years ago

Hi @hems, can you tell me what's going on about the "API" link? I didn't have any problems, could you create an issue on our frontend repository?

Regarding the algorithm trading, we're currently working on a client javascript sdk and a better interface to run algorithms that enables you running them on a local server...

hems commented 8 years ago

@cesardeazevedo when i click "API" on https://foxbit.exchange it just links me to a #, i didn't check the other websites. Probably not a blinktrade problem, my bad!