search

blinktrade / bitex

BlinkTrade - Open Source Bitcoin Exchange
GNU General Public License v3.0
428 stars 233 forks source link

Database fields too short #23

Open pjz opened 9 years ago

pjz commented 9 years ago

Currently Broker has:

phone_number_1        = Column(String(15))
phone_number_2        = Column(String(15))
skype                 = Column(String(30))
email                 = Column(String(15))

which strike me as a bit... short. Your demo data (in bootstrap/demo.ini) thinks so too, since it overflows the email field (len("user@blinktrade.com") is > 15).

My suggested fix is to make phone numbers 30 characters and skype and email 254 characters. I could submit a PR, but I don't know how you guys are doing schema change management so didn't want to trample on it and risk messing with someone's live database.

Also, the name field in DepositMethods should likely be increased to 30; the current 15 is overflowed by demo.ini's usps_money_order.

pinhopro commented 9 years ago

Good point. Since I am using sqlite3, I didn't catch those. I will be replacing those.

Thanks