search

blinktrade / frontend-legacy

GNU General Public License v3.0
121 stars 182 forks source link

Add 'limit' parameter to orderbook method #235

Open felipedrumond opened 7 years ago

felipedrumond commented 7 years ago

There is no way to limit the required quantity of bids/asks. This returns a large amount of data impacting the response time of the request. As the majority of the returned data might be unnecessary, a limit param would reduce the amount of data, improving the response time.

cesardeazevedo commented 7 years ago

There's already a parameter for that, it's called MarketDepth, and according to fix protocol, you should pass 0 to get the full orderbook or pass the quantity that you wish.

And we are indeed not making using of the MarketDepth at all (https://github.com/blinktrade/frontend/search?utf8=%E2%9C%93&q=getMDMarketDepth&type=)

I think the main problem for now is on the coinage theme which comes with unnecessary full order book on the initial page, and this has been a issue for a long time, i will try to get some time to work at it.

Thanks to point it out

felipedrumond commented 7 years ago

Hi @cesardeazevedo. Looking more carefully at the response, I realized that it contains 4120 bids and 2638 asks. Not sure why they have different array sizes, but I guess they are different because the response might contain the entire orderbook. Moreover, the response is around 600KB and response times are 1.5-5.5 seconds. I hope the fix for this doesn't take you much time!