blinry / wikidata-cardgame

Use Wikidata to generate fact cards on arbitrary topics!
https://cardgame.morr.cc
64 stars 7 forks source link

Clearer Description: only 'instance of' properties are checked, not 'subclass of' #8

Closed micgro42 closed 5 years ago

micgro42 commented 5 years ago

The description is a bit non-obvious:

We fetch items from Wikidata which are instances of arbitrary subclasses of the topic provided in the URL.

When reading quickly, this could be interpreted as checking not only the instance of (P31) property, but also subclass of (P279). However, that doesn't seem to be the case, because there is no mushroom card game, even though fly agaric is a subclass of psychoactive mushroom which is a subclass of mushroom.

blinry commented 5 years ago

Thanks for mentioning this! In fact, currently, the query uses the relation wdt:P31/wdt:P279*, which means there must be exactly one P31, and then arbitraryily many P279's to get to the topic. I guess we could make the P31 optional?

blinry commented 5 years ago

Yeah, that doesn't make things worse! No mushroom decks, though – none of them seem to have time- or quantity-based properties :( Stuff like this works how, however: Raspberry Pi models

See #9 about maybe making better animal and plant (and mushroom!!!) decks, in the future! :)