search

blipk / Customised-Workspaces

Customised Isolated Workspaces - Gnome-Shell Extension
Other
68 stars 6 forks source link

[Feature Request] Add GNOME 45 Support #49

Closed scottAnselmo closed 11 months ago

scottAnselmo commented 11 months ago

Please include the debug file from ~/.config/worksets@blipk.xyz/debug.log and fill out the following sections

Desktop:

Describe the bug

GNOME Extensions comments that "The extension is incompatible with the current GNOME version". Selecting "Settings" outputs an error. This is expected behavior as the most recent version listed on https://extensions.gnome.org/extension/1583/worksets/ is 44, not 45. However, as 45 has been out for two and a half months it should be reasonably stable to have the extension supported on 45.

GNOME 45 was released on September 20, 2023: https://release.gnome.org/45/

To Reproduce Steps to reproduce the behavior:

  1. Go to https://extensions.gnome.org/extension/1583/worksets/
  2. Note that the most recent supported GNOME version is 44.

Expected behavior Extension is listed for 45 on extensions.gnome.org and able to execute

Screenshots Error output:

The settings of extension worksets@blipk.xyz had an error:

SyntaxError: import declarations may only appear at top level of a module

Stack trace:

@file:///var/home/[user]/.local/share/gnome-shell/extensions/worksets@blipk.xyz/prefs.js:29:28
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
blipk commented 11 months ago

I might get around to it eventually, or someone can submit a PR.

scottAnselmo commented 11 months ago

Actually I don't like your attitude.

"However, as 45 has been out for two and a half months it should be reasonably stable to have the extension supported on 45."

This was a comment on how often folk will suggest for upgrades to let it sit between a week or until the first point release. Arch/Manjaro can be temperamental, so if you were seeing some issue on your system testing following the GNOME 45 release and were waiting for upstream, GNOME 45, to be more stable I was commenting that hopefully whatever issues you might have seen are patched upstream to allow for Customized Workspace to be released for GNOME 45. It wasn't a comment on your capacity as a developer or seeking to demean your work that allowed GNOME Shell to have a feature KDE's Plasma includes.

blipk commented 11 months ago

It's no problem @sanecito, just a misunderstanding.

There are a lot of changes to the extension system in gnome-shell 45, I don't use this extension myself anymore, and I don't really have the inclination to update it for the changes.

A PR is welcomed, or I may consider archiving this repository eventually.

EDIT: I've moved discussion to a new issue

blipk commented 9 months ago

Hey @sanecito

I've updated everything for gnome 45, if you're still interested it would be good if you could use the preview .zip from this repo and give it a test.

Report any issues and any errors in the debug file: ~/.config/worksets@blipk.xyz/debug.log