search

blipk / Customised-Workspaces

Customised Isolated Workspaces - Gnome-Shell Extension
Other
68 stars 6 forks source link

[Bug] Gnome 45.4 wallpaper management does not work #53

Closed azakharchenko-msol closed 7 months ago

azakharchenko-msol commented 7 months ago

First of all Thank you for such great extension, it works perfect in latest stable debian (gnome 43.9). Unfortunately got an issue with the newer linux distribution. Please suggest the way of debugging/fixing the problem

Desktop:

Describe the bug

The wallpaper manager feature seems does not work, after switching the workspace the plugin sets the correct wallpaper, but it is changed into default in ~500 ms To Reproduce Steps to reproduce the behavior:

  1. install Majaro linux 23.1.4-24
  2. install plugin
  3. configure workspaces wallpapers
  4. try switch workspace

Expected behavior The workspace background is changed accordingly to settings

Screencast from 2024-04-24 21-39-10.webm

debug.log:

    ~  cat ~/.config/worksets@blipk.xyz/debug.log     
(worksets@blipk.xyz) [4/24/2024, 9:32:36 PM]:-> enable@file:///home/az/.local/share/gnome-shell/extensions/worksets@blipk.xyz/extension.js:62:17
:INFO   |  @----------|
(worksets@blipk.xyz) [4/24/2024, 9:32:36 PM]:-> enable@file:///home/az/.local/share/gnome-shell/extensions/worksets@blipk.xyz/extension.js:97:17
:INFO   |  @~.........|
(worksets@blipk.xyz) [4/24/2024, 9:34:16 PM]:-> enable@file:///home/az/.local/share/gnome-shell/extensions/worksets@blipk.xyz/extension.js:62:17
:INFO   |  @----------|
(worksets@blipk.xyz) [4/24/2024, 9:34:16 PM]:-> enable@file:///home/az/.local/share/gnome-shell/extensions/worksets@blipk.xyz/extension.js:97:17
:INFO   |  @~.........|
(worksets@blipk.xyz) [4/24/2024, 9:36:05 PM]:-> enable@file:///home/az/.local/share/gnome-shell/extensions/worksets@blipk.xyz/extension.js:62:17
:INFO   |  @----------|
(worksets@blipk.xyz) [4/24/2024, 9:36:05 PM]:-> enable@file:///home/az/.local/share/gnome-shell/extensions/worksets@blipk.xyz/extension.js:97:17
:INFO   |  @~.........|

session.json:

{
 "SessionName": "Default",
 "Default": "1",
 "Options": {
  "ShowNotifications": true,
  "ShowHelpers": true,
  "IsolateWorkspaces": false,
  "ShowPanelIndicator": true,
  "ShowWorkspaceOverlay": true,
  "CliSwitch": "2",
  "DebugMode": true,
  "HideAppList": false,
  "DisableWallpaperManagement": false,
  "ReverseMenu": false
 },
 "Worksets": [
  {
   "WorksetName": "1",
   "WindowData": null,
   "FavApps": [
    {
     "name": "firefox.desktop",
     "displayName": "Firefox Web Browser",
     "icon": "firefox",
     "exec": "/usr/lib/firefox/firefox %u"
    },
    {
     "name": "org.gnome.Nautilus.desktop",
     "displayName": "Files",
     "icon": "org.gnome.Nautilus",
     "exec": "nautilus --new-window %U"
    },
    {
     "name": "org.gnome.gedit.desktop",
     "displayName": "gedit",
     "icon": "org.gnome.gedit",
     "exec": "gedit %U"
    },
    {
     "name": "org.gnome.Terminal.desktop",
     "displayName": "Terminal",
     "icon": "org.gnome.Terminal",
     "exec": "gnome-terminal"
    },
    {
     "name": "org.manjaro.pamac.manager.desktop",
     "displayName": "Add/Remove Software",
     "icon": "system-software-install",
     "exec": "pamac-manager %U"
    }
   ],
   "BackgroundImage": "file:///home/az/.local/share/backgrounds/2024-04-24-21-26-03-istockphoto-503756482-1024x1024.jpg",
   "BackgroundImageDark": "file:///home/az/.local/share/backgrounds/2024-04-24-21-26-03-istockphoto-503756482-1024x1024.jpg",
   "BackgroundStyle": "ZOOM",
   "BackgroundStyleDark": "zoom"
  },
  {
   "WorksetName": "2",
   "WindowData": null,
   "BackgroundImage": "file:///home/az/.local/share/backgrounds/2024-04-24-21-24-45-istockphoto-1085287936-1024x1024.jpg",
   "BackgroundImageDark": "file:///home/az/.local/share/backgrounds/2024-04-24-21-24-45-istockphoto-1085287936-1024x1024.jpg",
   "BackgroundStyle": "ZOOM",
   "BackgroundStyleDark": "wallpaper",
   "FavApps": [
    {
     "name": "firefox.desktop",
     "displayName": "Firefox Web Browser",
     "icon": "firefox",
     "exec": "/usr/lib/firefox/firefox %u"
    },
    {
     "name": "org.gnome.Nautilus.desktop",
     "displayName": "Files",
     "icon": "org.gnome.Nautilus",
     "exec": "nautilus --new-window %U"
    },
    {
     "name": "org.gnome.gedit.desktop",
     "displayName": "gedit",
     "icon": "org.gnome.gedit",
     "exec": "gedit %U"
    },
    {
     "name": "org.gnome.Terminal.desktop",
     "displayName": "Terminal",
     "icon": "org.gnome.Terminal",
     "exec": "gnome-terminal"
    },
    {
     "name": "org.manjaro.pamac.manager.desktop",
     "displayName": "Add/Remove Software",
     "icon": "system-software-install",
     "exec": "pamac-manager %U"
    }
   ]
  },
  {
   "WorksetName": "3",
   "WindowData": null,
   "BackgroundImage": "file:///home/az/.local/share/backgrounds/2024-04-24-21-26-03-istockphoto-503756482-1024x1024.jpg",
   "BackgroundImageDark": "file:///home/az/.local/share/backgrounds/2024-04-24-21-26-03-istockphoto-503756482-1024x1024.jpg",
   "BackgroundStyle": "ZOOM",
   "BackgroundStyleDark": "zoom",
   "FavApps": [
    {
     "name": "firefox.desktop",
     "displayName": "Firefox Web Browser",
     "icon": "firefox",
     "exec": "/usr/lib/firefox/firefox %u"
    },
    {
     "name": "org.gnome.Nautilus.desktop",
     "displayName": "Files",
     "icon": "org.gnome.Nautilus",
     "exec": "nautilus --new-window %U"
    },
    {
     "name": "org.gnome.gedit.desktop",
     "displayName": "gedit",
     "icon": "org.gnome.gedit",
     "exec": "gedit %U"
    },
    {
     "name": "org.gnome.Terminal.desktop",
     "displayName": "Terminal",
     "icon": "org.gnome.Terminal",
     "exec": "gnome-terminal"
    },
    {
     "name": "org.manjaro.pamac.manager.desktop",
     "displayName": "Add/Remove Software",
     "icon": "system-software-install",
     "exec": "pamac-manager %U"
    }
   ]
  },
  {
   "WorksetName": "4",
   "WindowData": null,
   "BackgroundImage": "file:///home/az/.local/share/backgrounds/2024-04-24-21-26-00-istockphoto-1085287936-1024x1024.jpg",
   "BackgroundImageDark": "file:///home/az/.local/share/backgrounds/2024-04-24-21-26-00-istockphoto-1085287936-1024x1024.jpg",
   "BackgroundStyle": "ZOOM",
   "BackgroundStyleDark": "zoom",
   "FavApps": [
    {
     "name": "firefox.desktop",
     "displayName": "Firefox Web Browser",
     "icon": "firefox",
     "exec": "/usr/lib/firefox/firefox %u"
    },
    {
     "name": "org.gnome.Nautilus.desktop",
     "displayName": "Files",
     "icon": "org.gnome.Nautilus",
     "exec": "nautilus --new-window %U"
    },
    {
     "name": "org.gnome.gedit.desktop",
     "displayName": "gedit",
     "icon": "org.gnome.gedit",
     "exec": "gedit %U"
    },
    {
     "name": "org.gnome.Terminal.desktop",
     "displayName": "Terminal",
     "icon": "org.gnome.Terminal",
     "exec": "gnome-terminal"
    },
    {
     "name": "org.manjaro.pamac.manager.desktop",
     "displayName": "Add/Remove Software",
     "icon": "system-software-install",
     "exec": "pamac-manager %U"
    }
   ]
  }
 ],
 "workspaceMaps": {
  "Workspace0": {
   "defaultWorkset": "1",
   "currentWorkset": "1"
  },
  "Workspace1": {
   "defaultWorkset": "2",
   "currentWorkset": "2"
  },
  "Workspace2": {
   "defaultWorkset": "3",
   "currentWorkset": "3"
  },
  "Workspace3": {
   "defaultWorkset": "4",
   "currentWorkset": "4"
  },
  "Workspace4": {
   "defaultWorkset": "",
   "currentWorkset": ""
  },
  "Workspace5": {
   "defaultWorkset": "",
   "currentWorkset": ""
  },
  "Workspace6": {
   "defaultWorkset": "",
   "currentWorkset": ""
  },
  "Workspace7": {
   "defaultWorkset": "",
   "currentWorkset": ""
  },
  "Workspace8": {
   "defaultWorkset": "",
   "currentWorkset": ""
  },
  "Workspace9": {
   "defaultWorkset": "",
   "currentWorkset": ""
  }
 }
}
blipk commented 7 months ago

Thanks for the report @azakharchenko-msol

Looks like something changed in a gnome45 point release, was getting the dconf settings signals differently even though I changed nothing.

I've fixed that up, you can use the release in github or wait for it to be approved on extensions.gnome.org.

azakharchenko-msol commented 7 months ago

@blipk Confirm it works! Thank you very much

blipk commented 7 months ago

@azakharchenko-msol Thanks for confirming, and appreciating, people don't usually show it.

Btw if you're using the GitHub version, you won't get updates from extensions.gnome.org because of the version in the development metadata.json

Check for a release and force install it from there once it's approved: https://extensions.gnome.org/review/54115