search

blipk / Customised-Workspaces

Customised Isolated Workspaces - Gnome-Shell Extension
Other
68 stars 6 forks source link

Gnome3.38 #9

Closed adaschma closed 4 years ago

adaschma commented 4 years ago

Change needed for gnome-shell 3.38.0 which has arrived in Debian Sid (and will "soon" migrate to Debian testing). If anything is unclear or you have any other questions, don't hesitate to ask.

blipk commented 4 years ago

Thanks for your work Adam, especially going through the mess of 3.38.

I had been meaning to work on a compat version for everything before 3.38, seeing as there's going to be some overhauls in the next major version with promises of less/no breaking between versions after that. Shouldn't be too hard to fix this up, just need to swap the extension utils back in I removed some commits back, and then a compat check for the changes here. Not sure if I will get around to it anytime soon though.

I will go ahead and approve this, havent tested much but everything looks good.

blipk commented 4 years ago

hey @adamschmalhofer can I confirm this is working for you?

I just updated to Fedora 33 and 3.38.1 and not getting anything at all with this PR. Nothing in logs, nothing in looking glass, no extension.

I'm at a bit of a loss as to how to debug this hmm.

adaschma commented 4 years ago

We chatted over matrix.org and I just want to post a summery for anybody who happens to stumble on this. In the end blipk got it working. For some strange unknown reason the extension wasn't enabled by using gnome-tweaks, but it worked with gnome-extensions-app.