search

blipson89 / Synthesis

Synthesis is a universal object mapper for Sitecore
MIT License
75 stars 25 forks source link

Move config files to \App_Config\Modules folder #77

Closed coreyasmith closed 4 years ago

coreyasmith commented 5 years ago

Since Synthesis 9.1.0 and above requires Sitecore 9.1, we can move configs out of the \App_Config\Include catch-all folder into the \App_Config\Modules folder that was introduced with config layers in Sitecore 9.

blipson89 commented 5 years ago

I agree with the changes, but I'm going to hold off on merging this for a little bit as I want to include it in part of a larger strategy for supporting multiple Sitecore versions.

studert commented 4 years ago

Hey @coreyasmith

According to the docs, the \App_Config\Modules folder is reserved for Sitecore: https://doc.sitecore.com/developers/92/platform-administration-and-architecture/en/configuration-layers.html

Reserved for Sitecore use. Contains configuration files for official Sitecore modules, such as Web Forms for Marketers

Maybe it's a bit outdated. Just wanted to let you know.

coreyasmith commented 4 years ago

Closing this in light of @studert's discovery in the @Sitecore documentation. It's probably not a good idea to put configs for a 3rd-party module in a directory reserved for "official" @Sitecore modules. Nice find @studert!